Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (gcp/getRegion) handle regionName == "global" #1930

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

🐛 (gcp/getRegion) handle regionName == "global" #1930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading status checks…
🐛 (gcp/getRegion) handle regionName == "global"
@Shion1305
Shion1305 committed Sep 28, 2024

Verified

This commit was signed with the committer’s verified signature.
Shion1305 Shion Ichikawa
GPG key ID: DD170F002A2C7C30
Verified
Learn about vigilant mode
commit 2ae92afd06c8ddf9aa007259d59f1d972a03c3b2
3 changes: 3 additions & 0 deletions providers/gcp/gcp_provider.go
View file
Original file line number Diff line number Diff line change
@@ -48,6 +48,9 @@ func GetRegions(project string) []string {
}

func getRegion(project, regionName string) *compute.Region {
if regionName == "global" {
return &compute.Region{}
}
computeService, err := compute.NewService(context.Background())
if err != nil {
log.Println(err)