Extend Cloudflare provider #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for firewall Rate Limits as well as for Page Rules.
| for page := 1; ; page++ { | ||
| rateLimits, resultInfo, err := api.ListRateLimits(zoneID, cf.PaginationOptions{Page: page, PerPage: 10}) | ||
| if err != nil { | ||
| log.Println(err) |
There was a problem hiding this comment.
you return error, not need log in resource level
|
|
||
| pageRules, err := api.ListPageRules(zoneID) | ||
| if err != nil { | ||
| log.Println(err) |
|
|
||
| zones, err := api.ListZones() | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
why panic if it's return error?
There was a problem hiding this comment.
To be honest, I was copying the other services in this provider. I assumed there were reasons beyond my understanding for this madness... :)
I can definitely make it more proper Go, tho. Gimme a day or two.
| func (g *PageRulesGenerator) InitResources() error { | ||
| api, err := g.initializeAPI() | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
why panic if it's return error?
| // Getting all firewall filters | ||
| tmpRes, err := f(api, zone.ID, zone.Name) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
why panic if it's return error?
|
@zorkian Thanks for you contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for firewall Rate Limits as well as for Page Rules in the Cloudflare provider.