WIP: Allow label/target search for ResultStore sources. #1296
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michelle192837
changed the title
|
Found an issue with a growing number of goroutines that didn't pop up on a simple search but does with a more complex search. I need to fix that before this is good to roll out. |
Instead of requiring `label:"prow"` in queries, allow any number of label or target atoms in a query. (This still limits the queries we accept, but it should work for most simple uses of ResultStore sources). Test: Unit tests, and verified with a local instance of TestGrid that a ResultStore source config will pick up results from ResultStore correctly.
michelle192837
force-pushed
the
query
branch
from
4d3af7f to
584ede0
Compare
|
@michelle192837: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Instead of requiring
label:"prow"in queries, allow any number of label or target atoms in a query. (This still limits the queries we accept, but it should work for most simple uses of ResultStore sources).Test: Unit tests, and verified with a local instance of TestGrid that a ResultStore source config will pick up results from ResultStore correctly.