Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bazel platform support #469

Merged

Conversation

Sineaggi
Copy link
Contributor

Adds bazel platform support.

@njlr
Copy link

njlr commented Dec 19, 2024

Is someone able to review this?

@loosebazooka Are you a maintainer? Please can you take a look at this?

@njlr
Copy link

njlr commented Jan 24, 2025

@Sineaggi Looks like this can be merged now?

@Sineaggi
Copy link
Contributor Author

@njlr Somebody with write access would have to merge it.

@thesayyn
Copy link
Collaborator

Can you force push to kick CI? I can't merge without them being run.

@Sineaggi Sineaggi force-pushed the add-bazel-platform-support branch from 30055bc to 071f68e Compare January 24, 2025 18:05
@Sineaggi
Copy link
Contributor Author

@thesayyn done

@Sineaggi Sineaggi force-pushed the add-bazel-platform-support branch from 071f68e to cf92541 Compare January 24, 2025 18:06
@Sineaggi
Copy link
Contributor Author

@thesayyn I merged in main, perhaps being behind caused the build failure.

@thesayyn
Copy link
Collaborator

Lets see the CI, i'll merge anyway if its unrelated failure.

@thesayyn thesayyn merged commit 56c7201 into GoogleContainerTools:main Jan 24, 2025
7 of 9 checks passed
@Sineaggi Sineaggi deleted the add-bazel-platform-support branch January 25, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants