Allow configuring enablePlatformTags via plugins #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
eifinger
changed the title
eifinger
force-pushed
the
enable_platform_tags_plugin
branch
3 times, most recently
from
06a505d
to
06b7b90
Compare
|
Is there anything I can do to get the conversation started? |
eifinger
force-pushed
the
enable_platform_tags_plugin
branch
from
06b7b90
to
a9dbff8
Compare
eifinger
force-pushed
the
enable_platform_tags_plugin
branch
2 times, most recently
from
f9df0ba
to
374a46f
Compare
eifinger
force-pushed
the
enable_platform_tags_plugin
branch
from
374a46f
to
98788fb
Compare
eifinger
force-pushed
the
enable_platform_tags_plugin
branch
from
98788fb
to
a5cb0ec
Compare
eifinger
force-pushed
the
enable_platform_tags_plugin
branch
2 times, most recently
from
4a1d81a
to
ef66b4f
Compare
eifinger
force-pushed
the
enable_platform_tags_plugin
branch
from
ef66b4f
to
1169d6a
Compare
|
Maybe this is something you could look at @mpeddada1 ? |
eifinger
force-pushed
the
enable_platform_tags_plugin
branch
from
1169d6a
to
161464f
Compare
eifinger
force-pushed
the
enable_platform_tags_plugin
branch
from
161464f
to
5559f4d
Compare
eifinger
force-pushed
the
enable_platform_tags_plugin
branch
from
5559f4d
to
475b7e3
Compare
|
Is their any update or status of this MR? |
Creates a new config parameter jib.to.enablePlatformTags and passes it through to the build context.
eifinger
force-pushed
the
enable_platform_tags_plugin
branch
from
475b7e3
to
64ffa13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your interest in contributing! For general guidelines, please refer to
the contributing guide.
Before filing a pull request, make sure to do the following:
the style guide.
This helps to reduce the chance of having a pull request rejected.
Fixes #3518🛠️
This PR tries to pick up #3710
I added the requested integration test
testSteps_forBuildToDockerRegistry_multiplePlatforms