Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: primitive support for multiple WWW-Authenticate response headers (GoogleContainerTools#4187) #4188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kosi2801
Copy link

  • fix: try all authenticate methods from the WWW-Authenticate response header until one succeeds

Thank you for your interest in contributing! For general guidelines, please refer to
the contributing guide.

Before filing a pull request, make sure to do the following:

  • Create a new issue at https://github.com/GoogleContainerTools/jib/issues/new/choose.
  • Ensure that your implementation plan is approved by the team.
    • not yet discussed, implementation is based on local fix of issue
  • Verify that integration tests and unit tests are passing after the change.
    • local docker instance as described in integration test instructions doesn't seem accessible for whatever reason. unit tests pass.
  • Address all checkstyle issues. Refer to
    the style guide.

This helps to reduce the chance of having a pull request rejected.

Fixes #4187 🛠️

…rs (GoogleContainerTools#4187)

* fix: try all authenticate methods from the `WWW-Authenticate` response header until one succeeds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image pull fails when repository answers with optional unsupported WWW-Authenticate header
1 participant