Race condition on google-client-loader #75 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -140,6 +140,9 @@ | |||
| ready: function() { | |||
| this._loader = document.createElement('google-js-api'); | |||
| this.listen(this._loader, 'js-api-load', '_loadClient'); | |||
| if (this._loader.libraryLoaded) { | |||
| this._loader.fire('js-api-load',{}); | |||
There was a problem hiding this comment.
space indent. You can also get rid of 2nd arg
There was a problem hiding this comment.
Can you take care of this one?
|
I ran into this problem too, and the PR fixed it. |
ssalbdivad
approved these changes
Mar 5, 2017
|
Also ran into this issue, would be great to get this merged! |
peterfortuin
reviewed
Aug 7, 2019
| @@ -140,6 +140,9 @@ | |||
| ready: function() { | |||
| this._loader = document.createElement('google-js-api'); | |||
| this.listen(this._loader, 'js-api-load', '_loadClient'); | |||
| if (this._loader.libraryLoaded) { | |||
| this._loader.fire('js-api-load'); | |||
There was a problem hiding this comment.
Actually, the listening for the js-api-load event is not needed if the library is already loaded. This can be replaced by:
if (this._loader.libraryLoaded) {
this._loadClient();
} else {
this.listen(this._loader, 'js-api-load', '_loadClient');
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.