Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 fix(ticket): 티켓 에러, 로직 배포용으로 변경 #111 #115

Merged
merged 1 commit into from
Aug 2, 2022
Merged

🔨 fix(ticket): 티켓 에러, 로직 배포용으로 변경 #111 #115

merged 1 commit into from
Aug 2, 2022

Conversation

gengminy
Copy link
Member

@gengminy gengminy commented Aug 2, 2022

📝 PR Summary

티켓 에러, 로직 배포용으로 변경

🌲 Working Branch

feature/ticket

🌲 TODOs

  • 티켓 상태 Enum 변경에 따른 에러 메세지 변경
  • 티켓 find 기본 정렬 createdAt -> id로
  • 티켓 find PageOptionsDto skip이랑 take isOptional -> false 로
  • 티켓 find user, admin 컬럼 UserProfileDto 로 변경
  • 티켓 테스트용 메소드 컨트롤러에서 삭제
  • 불필요한 모듈 임포트 삭제
  • 코드 최적화

Related Issues

#111 #89

@gengminy gengminy requested a review from ImNM August 2, 2022 14:59
@gengminy gengminy self-assigned this Aug 2, 2022
@gengminy gengminy added For: Deploy [이슈대상] 배포에 관한 이슈 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 Type: Errors/Bugs [이슈 목적] 버그, 애러 수정 labels Aug 2, 2022
ImNM
ImNM approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고입니다 !!! 수고많으셨어용

@ImNM ImNM merged commit 62e0053 into dev Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImNM ImNM ImNM approved these changes

Assignees

@gengminy gengminy

Labels
For: Deploy [이슈대상] 배포에 관한 이슈 Type: Errors/Bugs [이슈 목적] 버그, 애러 수정 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gengminy @ImNM