Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpack: fix Invalid cross-device link errors #299

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Gottox
Copy link
Owner

@Gottox Gottox commented Dec 7, 2024

sqsh-unpack uses temporary files to store the extracted data. The temporary files were always created in the current working directory. This could lead to "Invalid cross-device link" errors when the current working directory is on a different file system than the target directory.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.24%. Comparing base (b53e227) to head (c0c3819).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tools/src/unpack.c 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   64.08%   64.24%   +0.16%     
==========================================
  Files          75       75              
  Lines        5898     5958      +60     
  Branches      903      904       +1     
==========================================
+ Hits         3780     3828      +48     
- Misses       1580     1591      +11     
- Partials      538      539       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gottox Gottox force-pushed the fix/invalid-cross-device-link branch from 94e414c to f4e80d1 Compare December 7, 2024 14:23
sqsh-unpack uses temporary files to store the extracted data. The
temporary files were always created in the current working directory.
This could lead to "Invalid cross-device link" errors when the
current working directory is on a different file system than the
target directory.
@Gottox Gottox force-pushed the fix/invalid-cross-device-link branch from f4e80d1 to c0c3819 Compare December 7, 2024 14:25
Copy link

sonarqubecloud bot commented Dec 7, 2024

@Gottox Gottox merged commit b2b0b2f into main Dec 7, 2024
19 checks passed
Gottox added a commit that referenced this pull request Dec 8, 2024
unpack: fix `Invalid cross-device link errors`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant