Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare publish of com.gradleup.shadow #930

Merged
merged 24 commits into from
Aug 8, 2024
Merged

Prepare publish of com.gradleup.shadow #930

merged 24 commits into from
Aug 8, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Aug 1, 2024

  • Plugin id from com.github.johnrengelman.shadow to com.gradleup.shadow.
  • Support publishing to MavenCentral and with snapshots support.
  • Add release workflows.
  • Add changelog and releasing.
  • Update original repo ref links.

@Goooler
Copy link
Member Author

Goooler commented Aug 1, 2024

It's here https://oss.sonatype.org/content/repositories/snapshots/com/gradleup/shadow/.

.github/workflows/release.yml Outdated Show resolved Hide resolved
@Goooler Goooler force-pushed the publish-infra branch 3 times, most recently from 847d8d6 to dbd8ca2 Compare August 5, 2024 01:26
@breandan
Copy link

breandan commented Aug 5, 2024

Tried id("com.gradleup.shadow") version "8.3.0-SNAPSHOT", but received the following error:

* What went wrong:
Plugin [id: 'com.gradleup.shadow', version: '8.3.0-SNAPSHOT'] was not found in any of the following sources:

- Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
- Included Builds (None of the included builds contain this plugin)
- Plugin Repositories (could not resolve plugin artifact 'com.gradleup.shadow:com.gradleup.shadow.gradle.plugin:8.3.0-SNAPSHOT')
  Searched in the following repositories:
    MavenRepo
    Gradle Central Plugin Repository

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

Nevermind, I added: maven("https://oss.sonatype.org/content/repositories/snapshots") to the settings.gradle.kts file and it works.

@Goooler
Copy link
Member Author

Goooler commented Aug 5, 2024

@breandan See ff01bde.

deepy and others added 2 commits August 6, 2024 09:06
The rule-generated `yarn_` tasks only get the dependency on the
YarnInstallTask if they start with `yarn_run_`

So to make sure `yarn_build` works I've added the dependency manually
src/docs/about/README.md Show resolved Hide resolved
gradle.properties Show resolved Hide resolved
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, none of my comments is a blocking one

@Goooler Goooler merged commit e652f1a into main Aug 8, 2024
9 checks passed
@Goooler Goooler deleted the publish-infra branch August 8, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants