Default ClusterIP for minikube bit allow LoadBalancer override.

GrahamDumpleton · Sep 20, 2024 · 05af649 · 05af649
1 parent e3a7423
commit 05af649
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.../bundle/config/ytt/_ytt_lib/infrastructure/minikube/10-default-settings-for-provider.yaml b/.../bundle/config/ytt/_ytt_lib/infrastructure/minikube/10-default-settings-for-provider.yaml
@@ -18,7 +18,7 @@ clusterPackages:
         defaultHttpVersions:
           - "HTTP/1.1"
       service:
-        type: LoadBalancer
+        type: ClusterIP
         useHostPorts: true
   cert-manager:
     enabled: #@ isClusterPackageEnableByDefault("cert-manager")

diff --git a/carvel-packages/installer/bundle/config/ytt/_ytt_lib/packages/contour/rules.star b/carvel-packages/installer/bundle/config/ytt/_ytt_lib/packages/contour/rules.star
@@ -1,5 +1,8 @@
 def check_infra(val):
-  if val["infraProvider"] in ["aws", "gcp", "azure", "minikube"]:
+  if val["infraProvider"] in ["minikube"]:
+    return val["service"]["type"] in ["ClusterIP", "LoadBalancer"] or fail("{} infra provider requires service.type to be ClusterIP or LoadBalancer".format(val["infraProvider"]))
+  end
+  if val["infraProvider"] in ["aws", "gcp", "azure"]:
     return val["service"]["type"] == "LoadBalancer" or fail("{} infra provider requires service.type to be LoadBalancer".format(val["infraProvider"]))
   end
   if val["infraProvider"] in ["kind"]: