feat: format currency with commas and strip unnecessary decimal 0s #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhult
requested review from
n1tranquilla,
trevorbernard,
robinbb and
Isaac-DeFrain
as code owners
n1tranquilla
requested changes
Oct 15, 2024
| @@ -445,6 +445,64 @@ pub fn decorate_with_currency_tag( | |||
| .into() | |||
| } | |||
|
|
|||
| /// Format currency by stripping out the decimal if it is 0 and calling | |||
| /// [format_with_commas]. | |||
| pub fn strip_decimal_if_zero(num_str: String) -> String { | |||
There was a problem hiding this comment.
This is really tricky. You have to take into account localization (different kinds of number formatting). Fortunately I have already developed a function for this:
mina-block-explorer/src/common/functions.rs
Line 848 in 73d8ab3
For context, this is how numbers are represented in German locale:
Using the normalize function first will make a standard number (see unit tests on how), and then you can go from there.
There was a problem hiding this comment.
You could also update how this function works:
mina-block-explorer/src/common/functions.rs
Line 941 in 73d8ab3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure commas where they belong and remove any trailing 0s after the decimal.