Aarch64 support #34
Draft
Aarch64 support #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jongy
commented
Feb 4, 2022
Jongy
commented
Feb 4, 2022
| #elif defined(__aarch64__) | ||
| switch (pthreads_impl) { | ||
| case PTI_GLIBC: | ||
| // TODO const bad |
Jongy
commented
Feb 4, 2022
| break; | ||
|
|
||
| case PTI_MUSL: | ||
| // TODO ensure really same as x86 |
Jongy
commented
Feb 4, 2022
Jongy
commented
Feb 4, 2022
| #elif defined(__aarch64__) | ||
| switch (pthreads_impl) { | ||
| case PTI_GLIBC: | ||
| return (int64_t)(a - b) < 0x500; |
Jongy
commented
Feb 4, 2022
| // Yes - use the registers context given to the BPF program | ||
| user_regs = *ctx; | ||
| bpf_probe_read_kernel(&user_regs, sizeof(user_regs), ctx); |
There was a problem hiding this comment.
TODO figure this out - why these 2 lines do not have the same effect, as if bpf_probe_read_kernel fails.
TODO maybe because bpf_probe_read_kernel doesn't exist in pre-5.4, so this read fails???
Jongy
commented
Feb 4, 2022
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works! but not complete & not ready for CR yet. I will list the missing things to do in the respective gProfiler PR.