-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nginx Signing Key Update #24
base: master
Are you sure you want to change the base?
Nginx Signing Key Update #24
Conversation
…ure releases and break functionality (like with 3.12.4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments please
fi | ||
#set -- $i | ||
set -- ${services[@]} | ||
echo $1 $2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like debug print that already printed below
else | ||
echo -e "[${RED}ERROR${NC}] container $2 unreachable from $1" | ||
fi | ||
#set -- $i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the comments
Description
The signing key that comes with the repo is causing signing errors. Either need to add instructions to the README to update signing key to the most relevant one or use the one included in this pull request. (From https://github.com/user-attachments/assets/a56d320a-cc97-4967-b59f-9a07cb0eec00)
Motivation and Context
Current pull from a repo blocks the docker compose build because the signing key throws a signing error
How Has This Been Tested?
Tested this setting up Gprofiler Performance Studio on c7i.4xl in AWS on U22.04
Screenshots
Checklist:
I have not added any instructions to the README, but that is an alternate solution
No new logic added