logger message severity changed for wrong token #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-ol
reviewed
May 22, 2023
gprofiler/main.py
Outdated
| @@ -1032,7 +1032,7 @@ def main() -> None: | |||
| else None | |||
| ) | |||
| except APIError as e: | |||
| logger.error(f"Server error: {e}") | |||
| logger.critical(f"Server error: {e}") | |||
There was a problem hiding this comment.
Wasn't the critical level applicable only for invalid API token?
At the same time we can change the "server error: invalid API key" log to be CRITICAL.
(see this comment)
A known-message check might be needed here to trigger the critical level message in that specific case.
@Jongy , take a look?
pfilipko1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Granulate/granulate-utils#146
and #676