WIP: Spark --app-id as container name #871
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jongy
commented
Dec 28, 2023
Comment on lines
+150
to
+151
| # container_names_client = ContainerNamesClient() if self._enrichment_options.container_names else None | ||
| container_names_client = SparkContainerNamesClient() if self._enrichment_options.container_names else None |
There was a problem hiding this comment.
This needs to be made a CLI argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a redo of the branch
spark-app-id-as-container-name(from cf74924).The idea is to allow using Spark application IDs as "container names" collected by gProfiler. Logically, a "container name" is just an identifier describing a process or a set of processes across (potentially) multiple nodes. For Docker/k8s/ecs etc, container names are logical. In Spark/YARN, application IDs or YARN application names can be used instead.
I turned
ContainerNamesClientto a generic baseContainerNamesClientBasewhich is implemented byContainerNamesClient(the old) andSparkContainerNamesClient(the new).Related Issue
#869
How Has This Been Tested?
T.B.D