Fixes build issue with CentOS7 and modified gitmodules to use https like parent repo for consistency #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert granulate-utils change
Jongy
reviewed
Aug 19, 2024
executable.Dockerfile
Outdated
Comment on lines
77
to
79
| # Workaround for CentOS7 EOL | ||
| RUN sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* | ||
| RUN sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-* |
There was a problem hiding this comment.
Let's move to some .sh script so it can be reused.
|
Superseded by: #917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for executable and docker builds that fail due to CentOS7 EOL
Description
Related Issue
Motivation and Context
Allows for the project to build. Ideally should change th eunderlying images to newer ones.
How Has This Been Tested?
Tested on-prem and AWS system on Ubuntu 22.04.
Screenshots
Checklist: