Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU backend branch merge #148

Open
wants to merge 117 commits into
base: master
Choose a base branch
from
Open

GPU backend branch merge #148

wants to merge 117 commits into from

Conversation

AjayBrahmakshatriya
Copy link
Member

@AjayBrahmakshatriya AjayBrahmakshatriya commented Mar 19, 2021

This PR is to merge the GPU backend branch changes into the master branch. Following things have been taken care of -

  1. No merge conflicts
  2. Project builds properly
  3. All tests including c++ tests, python tests (with and without schedules) and gpu_tests are passing
  4. GPU backend code changed to adapt to the functor changes introduced
  5. The CGO'21 AE is added to the repo and all applications are successfully running.

AjayBrahmakshatriya and others added 30 commits September 22, 2019 22:52
@yunmingzhang17 yunmingzhang17 marked this pull request as ready for review March 19, 2021 15:04
Copy link
Collaborator

@yunmingzhang17 yunmingzhang17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good. It's a big PR, let's test it a bit more.

@@ -0,0 +1,10 @@
#ifndef PRIORITY_QUEUE_FRONTIER_REUSE_H
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an empty file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an incomplete feature I was trying to implement. This shouldn't have been added. I will remove it.

void ExtractReadWriteSet::visit(mir::StmtBlock::Ptr stmt_block) {
return;
}
void ExtractReadWriteSet::visit(mir::TensorArrayReadExpr::Ptr tare) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use a more meaningful variable name, not "tare". In general, it would be easier if we don't use the acronyms.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I have been a bit liberal with all the names here. I can take a pass and clean up all the variable names used in the GPU backend and the related passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants