-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU backend branch merge #148
base: master
Are you sure you want to change the base?
Conversation
…edule is attached
…ator lowering done
…and adding a real delta stepping version
…ould lower into ordered processing operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good. It's a big PR, let's test it a bit more.
@@ -0,0 +1,10 @@ | |||
#ifndef PRIORITY_QUEUE_FRONTIER_REUSE_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this an empty file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an incomplete feature I was trying to implement. This shouldn't have been added. I will remove it.
void ExtractReadWriteSet::visit(mir::StmtBlock::Ptr stmt_block) { | ||
return; | ||
} | ||
void ExtractReadWriteSet::visit(mir::TensorArrayReadExpr::Ptr tare) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a more meaningful variable name, not "tare". In general, it would be easier if we don't use the acronyms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I have been a bit liberal with all the names here. I can take a pass and clean up all the variable names used in the GPU backend and the related passes.
Fixed minor Codegen bug for AE
This PR is to merge the GPU backend branch changes into the master branch. Following things have been taken care of -