Skip to content

Perf query cell #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Perf query cell #762

wants to merge 2 commits into from

Conversation

xuewenjie123
Copy link
Collaborator

image
image

@vercel Vercel
Copy link

vercel bot commented May 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gsp ❌ Failed (Inspect) May 19, 2025 2:22am

github-advanced-security[bot]
github-advanced-security bot found potential problems May 19, 2025
View reviewed changes
packages/studio-query/src/components/QueryCell/index.tsx

// 关系箭头指向错误
{
wrong: /-->/g,

Check failure

Code scanning / CodeQL

Bad HTML filtering regexp High

This regular expression only parses --> and not --!> as a HTML comment end tag.

Copilot Autofix

AI 4 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

packages/studio-query/src/components/QueryCell/index.tsx

// 未关闭括号
{
wrong: /\((?:[^)(]+|\((?:[^)(]+|\([^)(]*\))*\))*$/,

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with '(' and containing many repetitions of '''.

Copilot Autofix

AI 4 months ago

To fix the issue, we need to rewrite the regular expression to eliminate the ambiguity that causes exponential backtracking. Specifically, we can replace the ambiguous [^)(]+ with a more precise sub-expression that avoids overlapping matches. Additionally, we can use a more structured approach to match nested parentheses, such as leveraging a library like xregexp for recursive patterns if necessary.

In this case, we will rewrite the regex to use a non-ambiguous pattern for matching nested parentheses. The updated regex will ensure linear time complexity while preserving the original functionality.

Suggested changeset 1
packages/studio-query/src/components/QueryCell/index.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/studio-query/src/components/QueryCell/index.tsx b/packages/studio-query/src/components/QueryCell/index.tsx
--- a/packages/studio-query/src/components/QueryCell/index.tsx
+++ b/packages/studio-query/src/components/QueryCell/index.tsx
@@ -189,3 +189,3 @@
     { 
-      wrong: /\((?:[^)(]+|\((?:[^)(]+|\([^)(]*\))*\))*$/,
+      wrong: /\((?:[^)(]*\((?:[^)(]*\([^)(]*\))*[^)(]*\))*[^)(]*$/,
       correct: (match: string) => `${match})`, 
EOF
@@ -189,3 +189,3 @@
{
wrong: /\((?:[^)(]+|\((?:[^)(]+|\([^)(]*\))*\))*$/,
wrong: /\((?:[^)(]*\((?:[^)(]*\([^)(]*\))*[^)(]*\))*[^)(]*$/,
correct: (match: string) => `${match})`,
Copilot is powered by AI and may make mistakes. Always verify output.
packages/studio-query/src/components/QueryCell/index.tsx

// 未关闭括号
{
wrong: /\((?:[^)(]+|\((?:[^)(]+|\([^)(]*\))*\))*$/,

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with '((' and containing many repetitions of '''.

Copilot Autofix

AI 4 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xuewenjie123