Code

refactor: code cleanup#2519

Code

Draft

brenoepics wants to merge 68 commits intoGrasscutters:developmentGrasscutters/Grasscutter:developmentfrom brenoepics:developmentbrenoepics/Grasscutter:developmentCopy head branch name to clipboard

+1,777-3,020

Commits

Commits on Jun 9, 2024

• fix: make those fields final

  brenoepics

  committed
  6bb349d

• refactor: make getGoodsLimit one liner

  brenoepics

  committed
  da61d30

• refactor: replace size() == 0 with isEmpty()

  brenoepics

  committed
  ef58ab3

• refactor: remove unnecessary toString call

  brenoepics

  committed
  c3eafba

• refactor: remove unnecessary semicolons

  brenoepics

  committed
  029ef82

• refactor: unwrap redundant code block

  brenoepics

  committed
  9fa0f2b

• refactor: this can also be final

  brenoepics

  committed
  7d3abb0

• refactor: replace protected with private for final class

  brenoepics

  committed
  ca6ddfd

• refactor: replace protected with private for final class

  brenoepics

  committed
  0161b4d

• fix: variable is assigned to itself

  brenoepics

  committed
  427a1cf

• chore: remove unused import

  brenoepics

  committed
  9c946e9

• refactor: replace Collections.sort with list.sort

  Show description for 8c35c89
  brenoepics

  committed
  8c35c89

• refactor: replace lambda with method reference

  brenoepics

  committed
  870085f

• refactor: replace lambda with method reference

  brenoepics

  committed
  3119e0f

• refactor: simplify map operations

  Show description for c7119aa
  brenoepics

  committed
  c7119aa

• refactor: replace statement with expression lambda

  brenoepics

  committed
  fcd4093

• refactor: we don't need explicit types here

  brenoepics

  committed
  b5d0afd

• refactor: replace for loop with enhanced loop

  brenoepics

  committed
  bb82e21

• refactor: Integer.ParseInt is more appropriate here

  brenoepics

  committed
  6d669bd

• refactor: Integer.ParseInt is more appropriate here

  brenoepics

  committed
  7db8b6f

• refactor: replace switch with enhanced switch

  brenoepics

  committed
  c9b42a6

• refactor: fix javadoc issues

  brenoepics

  committed
  77e2462

• refactor: replace concatenation log with parameterized

  brenoepics

  committed
  6e7418a

• fix: integer division in floating point

  brenoepics

  committed
  d5ad077

• refactor: implicit cast from double to float may be lossy

  brenoepics

  committed
  6e3b3b2

• perf: Call to 'asList()' with only one argument

  brenoepics

  committed
  4f1ad7b

• perf: class initializer may be static

  brenoepics

  committed
  e4123f4

• perf: count > 0 can be anyMatch

  brenoepics

  committed
  b773529

• perf: findAny().isPresent() is cleaner here

  brenoepics

  committed
  33d5c52

• perf: fix redundant addAll

  brenoepics

  committed
  1424405

• perf: we can chain append here

  brenoepics

  committed
  1e2ccc9

• perf: equals "" can be isEmpty here

  brenoepics

  committed
  aeadf6b

• perf: add Serial annotation here

  brenoepics

  committed
  7ee644c

• refactor(lombok): add Getter where possible

  brenoepics

  committed
  8f4120f

• refactor(lombok): add Setter where possible

  brenoepics

  committed
  dd9f59f

• perf: this is just Math.min

  brenoepics

  committed
  4b03304

• perf: size cannot be negative

  brenoepics

  committed
  f01da54

• perf: simplify optional chain

  brenoepics

  committed
  8f8a6a7

• perf: remove redundant collection operation

  brenoepics

  committed
  85ca877

• perf: we can just equalsIgnoreCase

  brenoepics

  committed
  3d00abc

• perf: stream api can be simplified here

  brenoepics

  committed
  45bf5ed

• refactor: null check is not necessary, we have instanceof

  brenoepics

  committed
  809009f

• chore: fix codestyle indentation

  brenoepics

  committed
  db28038

• refactor: number comparison

  brenoepics

  committed
  3b68645

• refactor: fix nullable params

  brenoepics

  committed
  d4ce7aa

• Format code [skip actions]

  github-actions[bot]

  committed
  8c53f2b

• refactor: fix lombok

  brenoepics

  committed
  bfc2c7c

• Format code [skip actions]

  github-actions[bot]

  committed
  2bb2da4

• ci: bump actions

  brenoepics

  committed
  dbb4f85

• Merge branch 'development' of https://github.com/brenoepics/Grasscutter into development

  brenoepics

  committed
  c313939

• ci: Create dependabot.yml

  brenoepics

  authored
  1234d18

• chore(deps): bump com.google.protobuf:protoc from 3.18.1 to 4.27.1

  Show description for 62d53f3
  dependabot[bot]

  authored
  62d53f3

• chore(deps): bump com.fasterxml.jackson:jackson-bom

  Show description for 52b7ca6
  dependabot[bot]

  authored
  52b7ca6

• chore(deps): bump org.jline:jline-terminal-jna from 3.21.0 to 3.26.1

  Show description for bbec09d
  dependabot[bot]

  authored
  bbec09d

• chore(deps): bump org.junit.jupiter:junit-jupiter-engine

  Show description for ff2aeac
  dependabot[bot]

  authored
  ff2aeac

• security: add secure mode and padding scheme

  brenoepics

  committed
  63fbe66

• Merge branch 'development' of https://github.com/brenoepics/Grasscutter into development

  brenoepics

  committed
  75d8ed0

• Format code [skip actions]

  github-actions[bot]

  committed
  0736956

• Merge pull request #1 from brenoepics/dependabot/gradle/com.google.protobuf-protoc-4.27.1

  Show description for fa283d8
  brenoepics

  authored
  fa283d8

• Merge pull request #2 from brenoepics/dependabot/gradle/com.fasterxml.jackson-jackson-bom-2.17.1

  Show description for 22c7f3c
  brenoepics

  authored
  22c7f3c

• Merge pull request #3 from brenoepics/dependabot/gradle/org.jline-jline-terminal-jna-3.26.1

  Show description for a05d6cd
  brenoepics

  authored
  a05d6cd

• Merge pull request #4 from brenoepics/dependabot/gradle/org.junit.jupiter-junit-jupiter-engine-5.10.2

  Show description for cd48328
  brenoepics

  authored
  cd48328

Commits on Jun 10, 2024

• chore(deps): bump org.java-websocket:Java-WebSocket from 1.5.2 to 1.5.6

  Show description for 011549f
  dependabot[bot]

  authored
  011549f

• chore(deps): bump ch.qos.logback:logback-core from 1.4.7 to 1.5.6

  Show description for 0819435
  dependabot[bot]

  authored
  0819435

• Merge pull request #9 from brenoepics/dependabot/gradle/ch.qos.logback-logback-core-1.5.6

  Show description for a0922ff
  brenoepics

  authored
  a0922ff

• Merge pull request #7 from brenoepics/dependabot/gradle/org.java-websocket-Java-WebSocket-1.5.6

  Show description for c77aa52
  brenoepics

  authored
  c77aa52

• chore(deps): bump org.slf4j:slf4j-api from 2.0.7 to 2.0.13

  Show description for ab5824b
  dependabot[bot]

  authored
  ab5824b

• Merge pull request #8 from brenoepics/dependabot/gradle/org.slf4j-slf4j-api-2.0.13

  Show description for 0e7e165
  brenoepics

  authored
  0e7e165