fix keys parse bug #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwme
commented
Dec 9, 2021
| @@ -59,7 +59,7 @@ func NewRootCmd() (*cobra.Command, params.EncodingConfig) { | |||
| return err | |||
| } | |||
|
|
|||
| gravityAppTemplate, gravityAppConfig := initAppConfig(); | |||
| gravityAppTemplate, gravityAppConfig := initAppConfig() | |||
There was a problem hiding this comment.
hmm, looks like my IDE removed the ; automatically but is more of a stylistic choice? feel free to add back or leave
There was a problem hiding this comment.
it's not a huge deal either way.
jkilpatr
reviewed
Dec 15, 2021
| @@ -114,6 +114,10 @@ func Execute(rootCmd *cobra.Command) error { | |||
| } | |||
|
|
|||
| func initRootCmd(rootCmd *cobra.Command, encodingConfig params.EncodingConfig) { | |||
|
|
|||
| cfg := sdk.GetConfig() | |||
| cfg.Seal() | |||
There was a problem hiding this comment.
digging into how this works it just seems strange. Pointer magic going on about sealing the config globally using a reference to it.
I can understand how this pattern would cause mistakes, shouldn't the way this works be modified in the sdk to avoid 'spooky action at a distance' which seems to be the root cause of this bug.
Anyways merging for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originally made the PR against here by mistake: althea-net/cosmos-gravity-bridge#366
same issue was present in gaia where the
keys parsecommand was hanging