-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/1978 add merge tags now today yesterday #2143
Issue/1978 add merge tags now today yesterday #2143
Conversation
@Mwalek, please test and ensure that it works properly with different timezones. |
Summary of Issues:
Test URL: https://gv-issue-2143.try.gravitykit.com/display-m-tag-view/ (test:test) |
Should Also, the default output of We need to be able to work on these conditions: https://docs.gravitykit.com/article/446-highlighting-entries-about-to-expire |
@Mwalek @rafaehlers I also tested it with gvlogic with now:timestamp and it worked |
@rafaehlers I'm still testing AF, but I can confirm that the new merge tags work with
|
@Mwalek Thanks for the detailed video, That's fixed now with the latest commit |
Thanks @omarkasem! @rafaehlers Do you want to propose any changes before I proceed to test the latest commit? |
@rafaehlers, please see @Mwalek's comment. |
No, that's it, we're good @Mwalek 👍 |
|
@Mwalek, was this fully tested? @omarkasem, I see some outstanding items in this comment. |
@mrcasual needed to test a bit more. It's fully tested now. Couldn't spot any issues on PHP 7.4 and 8.3, even while using AF. |
@omarkasem, please play attention to these changes as we keep repeating most of them on your code. More specifically: 1) Use Yoda conditions 2) Function description should use third-person singular verb to describe what it does (see https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#documenting-tips) 3) Reuse variables if declared and do not declare variable if it's only used once 4) Pass only the required parameters to functions
💾 Build file (97f8351).