-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update settings on template activation #2144
Update settings on template activation #2144
Conversation
@doekenorg, is this PR ready for review/testing? If so, please update the Project information, |
I updated the connected issue, but I have now updated this one as well. I'm not sure which I should update now. Doing both sounds too much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good code-wise @doekenorg 👍 Just a couple commented-out lines.
@Mwalek, please test. Make sure that everything is synchronized across 3 places where a layout can be selected. |
@doekenorg @mrcasual looks good! I tested with PHP versions 7.4 & 8.3. While testing this I found a few minor issues that are indirectly related to this functionality. @mrcasual before I create GH issues for them, could you please have a look and see if they're all things we want to fix? Loom Video: https://www.loom.com/share/0665547e6d8b4a7dbb500ef8fb0bb618
|
@Mwalek, the status indicator, upgrade badge, and confirmation messages are minor issues that should be corrected. What's more concerning is that when you click to install and use DataTables, the View type dropdown still shows Table. In the order of priority:
@doekenorg, over to you. |
…elements-after-installation-or-activation
I've created #2158 to address the other issues. |
@Mwalek Back to you for (hopefully final) testing. |
@doekenorg thank you! I retested this and can confirm that the following issues are resolved by the latest build:
|
…elements-after-installation-or-activation
This PR addresses #2117
After activating or installing a plugin, the selectors are updated; and the settings block is re-rendered and replaced. This will ensure all the new settings are available.
💾 Build file (12afca1).