Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes reversing issue #2157

Conversation

omarkasem
Copy link
Collaborator

@omarkasem omarkasem commented Sep 30, 2024

  • Fixes Survey field ratings are incorrect for Views embedded in other Views #2125
  • The issue was only happening if a gravity forms field is put before gravity view field
  • And that was happening because of a logic inside the survey plugin that was reversing the field choices for some reason that was being called when a gravity form is embedded in a page so it was affecting anything that comes after it that depend on field choices

image

💾 Build file (9e98a5f).

templates/fields/field-survey-html.php Outdated Show resolved Hide resolved
* @since TBD
*
* @param int $form_id The ID of the form.
* @param int $field_id The ID of the field.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omarkasem, please align param descriptions:

* @param int $form_id  The ID of the form.
* @param int $field_id The ID of the field.

@omarkasem
Copy link
Collaborator Author

@mrcasual Thanks for the notes, All done

@mrcasual mrcasual merged commit f593e47 into develop Oct 14, 2024
1 check passed
@mrcasual mrcasual deleted the issue/2125-survey-field-ratings-are-incorrect-for-views-embedded-in-other-views branch October 14, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Survey field ratings are incorrect for Views embedded in other Views
3 participants