-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes reversing issue #2157
Merged
mrcasual
merged 6 commits into
develop
from
issue/2125-survey-field-ratings-are-incorrect-for-views-embedded-in-other-views
Oct 14, 2024
Merged
Fixes reversing issue #2157
mrcasual
merged 6 commits into
develop
from
issue/2125-survey-field-ratings-are-incorrect-for-views-embedded-in-other-views
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackkatz
reviewed
Sep 30, 2024
mrcasual
requested changes
Oct 1, 2024
mrcasual
reviewed
Oct 2, 2024
mrcasual
reviewed
Oct 2, 2024
* @since TBD | ||
* | ||
* @param int $form_id The ID of the form. | ||
* @param int $field_id The ID of the field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omarkasem, please align param descriptions:
* @param int $form_id The ID of the form.
* @param int $field_id The ID of the field.
mrcasual
reviewed
Oct 2, 2024
mrcasual
reviewed
Oct 2, 2024
@mrcasual Thanks for the notes, All done |
…rect-for-views-embedded-in-other-views
mrcasual
deleted the
issue/2125-survey-field-ratings-are-incorrect-for-views-embedded-in-other-views
branch
October 14, 2024 16:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💾 Build file (9e98a5f).