Fix return value of wrapAll() when count() is 0 #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
$this->matches->count()
is 0 inQueryMutators::wrapAll()
it returns void, but the method is type hinted to returnDOMQuery
(the current object).Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
If matches is empty and you call
->wrapAll()
it will return null.What is the new behavior?
If matches is empty and you call
->wrapAll()
it will return theDOMQuery
object, as per the docblock return type.Does this introduce a breaking change?
Included in major release.