Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing usage of ReactDOM.findDOMNode. #20845

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dennisoelkers
Copy link
Member

Description

Motivation and Context

This PR is removing usages of ReactDOM.findDOMNode, according to the React 19 breaking changes.

/nocl No user-facing change.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers force-pushed the refactor/remove-react-find-dom-node branch 2 times, most recently from 0717a22 to 0c17c7b Compare November 1, 2024 11:22
@dennisoelkers dennisoelkers requested review from a team and linuspahl November 1, 2024 11:23
@dennisoelkers dennisoelkers force-pushed the refactor/remove-react-find-dom-node branch from 7f557b0 to 0ca1af8 Compare November 1, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant