Fixing unknown format issue when using gradient highlighting search page.
#20882
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
changed the title
unkown format issue when using gradiant highlighting.unknown format issue when using gradient highlighting.
linuspahl
changed the title
unknown format issue when using gradient highlighting.unknown format issue when using gradient highlighting search page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is fixing the
unknown formaterror which can occur for widgets on the search page, when using a gradient highlight.The error seems to happen since updating
chroma.jsfrom2.4.2to2.6.0.We are using
chroma.jsto generate the highlight background color and a contrasting text color. Before this PR we were generating a chroma color object for the gradient highlight color. When generating the contrasting text color, chroma threw an error, because the highlighting color has no mode:https://github.com/gka/chroma.js/blob/v2.6.0/dist/chroma.cjs#L182
The error message
unknown format: hex-color-valueis a bit misleading.With this PR we are just generating a hex color for the highlight instead of a color object.
Fixes #20876