Dev project bulk atac2 #1390
Open
Dev project bulk atac2 #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbind fails if mat isnt a sparseMatrix. this change makes safeSubset flexible to accept either matrix or dgCMatrix input
the params section of ArchRProj@embeddings needs to be a list rather than a vector. If a vector, when you try to pass a vector to dimsToUse, you cant have a vector of a vector so this gets converted to dimsToUse1, dimsToUse2, dimsToUse3 etc instead of dimsToUse = c(1,2,3). Discussed in #1379 (comment)
dimsToUse has to be the intersection of the dimensions that pass corCutOff and the dimensions originally listed in dimsToUse. also, the column subsetting of simRD has to happen before the second if statement to check if the dimensions match, otherwise this if statement will always fail and exit with an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1379
Issues with
projectBulkATAC()whendimsToUsehas been set.