Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing Sub-organizations as dropdown from the organization of a Grower #1124

Merged
merged 7 commits into from
Jan 12, 2024

Conversation

samwel141
Copy link
Contributor

@samwel141 samwel141 commented Oct 28, 2023

Description

managed to show the dropdown list of sub-organizations associated with an organization of a Grower

Issue(s) addressed
Issue number 886 under progress to be resolved

What kind of change(s) does this PR introduce?

  • [x ] Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfils these requirements

  • [x ] The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?

What is the new behavior?

now on checking an inline radio button the list of sub-organizations drops from organization name

Breaking change

May close issue: [#886](#886

@samwel141 samwel141 requested a review from a team as a code owner October 28, 2023 21:09
@gwynndp
Copy link
Collaborator

gwynndp commented Nov 24, 2023

@samwel141

Off to a nice start! Can you link to the issue that this PR resolves?
I think there are some open questions to answer before we can fully resolve this.

  • Do we want to show all the Sub-Orgs for the Organization on each grower, or only show the Organization and Sub-Orgs that they belong to
  • For a better UX we may need a way to tell the difference between the Org/Sub-Orgs the grower belongs to and the rest, if we want to list them all there

In the meantime, there is a display problem with your current implementation. It is also displaying on the Grower Cards in a jumbled way. See below:

Screenshot 2023-11-24 at 12 45 11 PM

On the card we might just want to list all of the organizations as comma-separated values to keep it compact, rather than have a dynamic dropdown.

package.json Outdated Show resolved Hide resolved
@samwel141
Copy link
Contributor Author

samwel141 commented Dec 16, 2023 via email

@samwel141
Copy link
Contributor Author

I have put everything clear in the UI can you give feedback on that also

@gwynndp
Copy link
Collaborator

gwynndp commented Jan 9, 2024

Looks much better. If you remove your package.json and package-lock.json changes then I'll merge.

@samwel141
Copy link
Contributor Author

Removed changes in the package.json and package-lock.json, so it is now clear.

@gwynndp gwynndp merged commit b35f612 into Greenstand:master Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants