Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue 352 husky commits #365

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brena-odwyer
Copy link

Hello,
I think I've solved the issue with husky and the pre-commits.
I just added two hooks on the pre-commit file and updated husky to the package.json

Comment on lines 1 to 2
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brena-odwyer thank you for your contribution, can you explain a little bit on this?
ling 1 and line 2?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw those lines while researching how to implement husky on stack overflow. The first line is a hashbang, it is like a special comment in Unix-like operating systems that specifies the interpreter for the script. The second line, from what I understand, is helping execute husky in different script locations. But I made a test on mine and tried commenting the second line (the same as the first) and it still worked the same way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I will try to run it on my side.

@dadiorchen
Copy link
Contributor

@brena-odwyer the failure of the ci is because that you didn't push your package-lock.json, please: npm install and push the lock file, it would solve the problem.

@brena-odwyer
Copy link
Author

Hi, just did! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants