Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config api #621

Merged
merged 3 commits into from
Mar 15, 2025

Fix int() and sections(), add more tests

2c35597
Select commit
Loading
Failed to load commit list.
Merged

Improve config api #621

Fix int() and sections(), add more tests
2c35597
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 15, 2025 in 1s

35.79% (+0.09%) compared to f1aa291

View this Pull Request on Codecov

35.79% (+0.09%) compared to f1aa291

Details

Codecov Report

Attention: Patch coverage is 82.58929% with 39 lines in your changes missing coverage. Please review.

Project coverage is 35.79%. Comparing base (f1aa291) to head (2c35597).

Files with missing lines Patch % Lines
...src/main/kotlin/world/gregs/config/ConfigReader.kt 85.11% 9 Missing and 23 partials ⚠️
...onfig/src/main/kotlin/world/gregs/config/Config.kt 22.22% 7 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...onfig/src/main/kotlin/world/gregs/config/Config.kt 15.78% <22.22%> (+15.78%) ⬆️
...src/main/kotlin/world/gregs/config/ConfigReader.kt 83.26% <85.11%> (+4.11%) ⬆️

... and 3 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #621      +/-   ##
============================================
+ Coverage     35.69%   35.79%   +0.09%     
- Complexity     4929     4949      +20     
============================================
  Files          1356     1355       -1     
  Lines         48253    48264      +11     
  Branches       9718     9714       -4     
============================================
+ Hits          17225    17277      +52     
+ Misses        27583    27542      -41     
  Partials       3445     3445              
Components Coverage Δ
Content 30.07% <ø> (+0.01%) ⬆️
Engine 43.37% <ø> (ø)
Network 71.90% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.