Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazy loaded CRC keys to cache interface for use in login protocol #622

Closed
wants to merge 2 commits into from

Conversation

titandino
Copy link
Contributor

Feel free to close if it's already implemented somewhere or not planned on being supported, but I didn't see any place where the client's CRCs are validated on login anywhere. Does 667 just not send these values or are they currently just being skipped on the login protocol?

…aded CRC values to the cache implementation so they can be utilized in the login protocol to validate cache version between client/server
@GregHib
Copy link
Owner

GregHib commented Mar 20, 2025

Hey, yeah Void is skipping the lobby login using two client changes and so doesn't need CRCs as they're only part of the lobby login protocol.

@titandino
Copy link
Contributor Author

titandino commented Mar 20, 2025 via email

@GregHib GregHib closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants