Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alter inverted index #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lyang24
Copy link

@lyang24 lyang24 commented Dec 1, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

!!! DO NOT LEAVE THIS BLOCK EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
    Added protobufs on SetColumnInvertedIndex and UnsetColumnInvertedIndex as this is the prerequisite for the implementation of alter column modify set/ unset inverted index in greptimedb.
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

@fengjiachun fengjiachun requested a review from zhongzc December 2, 2024 07:19
@lyang24 lyang24 marked this pull request as draft December 5, 2024 16:30
@lyang24 lyang24 force-pushed the alter_inverted_index branch 4 times, most recently from c86467f to 5af5b4e Compare December 10, 2024 04:46
@lyang24 lyang24 marked this pull request as ready for review December 12, 2024 07:11
@lyang24 lyang24 force-pushed the alter_inverted_index branch from 5af5b4e to 9c56862 Compare January 7, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant