chore: cleanup todos that should be panic (#3720)

Signed-off-by: tison <[email protected]>
GreptimeTeam · Apr 17, 2024 · 786f43d · 786f43d
1 parent 3e9bda3
commit 786f43d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/catalog/src/kvbackend/client.rs b/src/catalog/src/kvbackend/client.rs
@@ -506,32 +506,32 @@ mod tests {
         }
 
         async fn range(&self, _req: RangeRequest) -> Result<RangeResponse, Self::Error> {
-            todo!()
+            unimplemented!()
         }
 
         async fn batch_put(&self, _req: BatchPutRequest) -> Result<BatchPutResponse, Self::Error> {
-            todo!()
+            unimplemented!()
         }
 
         async fn compare_and_put(
             &self,
             _req: CompareAndPutRequest,
         ) -> Result<CompareAndPutResponse, Self::Error> {
-            todo!()
+            unimplemented!()
         }
 
         async fn delete_range(
             &self,
             _req: DeleteRangeRequest,
         ) -> Result<DeleteRangeResponse, Self::Error> {
-            todo!()
+            unimplemented!()
         }
 
         async fn batch_delete(
             &self,
             _req: BatchDeleteRequest,
         ) -> Result<BatchDeleteResponse, Self::Error> {
-            todo!()
+            unimplemented!()
         }
     }
 

diff --git a/src/script/src/python/engine.rs b/src/script/src/python/engine.rs
@@ -446,13 +446,13 @@ def test(**params) -> vector[i64]:
             ("a".to_string(), "30".to_string()),
             ("b".to_string(), "12".to_string()),
         ]);
-        let _output = script
+        let output = script
             .execute(params, EvalContext::default())
             .await
             .unwrap();
-        let res = match _output.data {
+        let res = match output.data {
             OutputData::RecordBatches(s) => s,
-            _ => todo!(),
+            data => unreachable!("data: {data:?}"),
         };
         let rb = res.iter().next().expect("One and only one recordbatch");
         assert_eq!(rb.column(0).len(), 1);
@@ -476,13 +476,13 @@ def test(number) -> vector[u32]:
             .compile(script, CompileContext::default())
             .await
             .unwrap();
-        let _output = script
+        let output = script
             .execute(HashMap::new(), EvalContext::default())
             .await
             .unwrap();
-        let res = common_recordbatch::util::collect_batches(match _output.data {
+        let res = common_recordbatch::util::collect_batches(match output.data {
             OutputData::Stream(s) => s,
-            _ => todo!(),
+            data => unreachable!("data: {data:?}"),
         })
         .await
         .unwrap();