fix: return empty path when extract function fails to extract

src/object-store/src/util.rs

@@ -123,18 +123,20 @@ pub fn normalize_path(path: &str) -> String {
     p
 }
 
-// This logical tries to extract parent path from the object storage operation
-// the function also relies on assumption that the region path is built from
-// pattern `<data|index>/catalog/schema/table_id/....`
-//
-// this implementation tries to extract at most 3 levels of parent path
+/// This logical tries to extract parent path from the object storage operation
+/// the function also relies on assumption that the region path is built from
+/// pattern `<data|index>/catalog/schema/table_id/....`
+///
+/// this implementation tries to extract at most 3 levels of parent path
+/// it returns empty string if there are less than 3 levels of path, to avoid
+/// invalid path extracted
 pub(crate) fn extract_parent_path(path: &str) -> &str {
     // split the path into `catalog`, `schema` and others
     path.char_indices()
         .filter(|&(_, c)| c == '/')
         // we get the data/catalog/schema from path, split at the 3rd /
         .nth(2)
-        .map_or(path, |(i, _)| &path[..i])
+        .map_or("", |(i, _)| &path[..i])
 }
 
 /// Attaches instrument layers to the object store.
@@ -208,13 +210,13 @@ mod tests {
 
         assert_eq!(
             "data/greptime/public",
-            extract_parent_path("data/greptime/public")
+            extract_parent_path("data/greptime/public/")
         );
 
-        assert_eq!("data/greptime/", extract_parent_path("data/greptime/"));
+        assert_eq!("", extract_parent_path("data/greptime/"));
 
-        assert_eq!("data/", extract_parent_path("data/"));
+        assert_eq!("", extract_parent_path("data/"));
 
-        assert_eq!("/", extract_parent_path("/"));
+        assert_eq!("", extract_parent_path("/"));
     }
 }