fix: determine region role by using is_readonly (#4725)

fix: correct `is_writable` behavior
GreptimeTeam · Sep 18, 2024 · befb6d8 · befb6d8
1 parent f73fb82
commit befb6d8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/mito2/src/engine.rs b/src/mito2/src/engine.rs
@@ -462,10 +462,10 @@ impl EngineInner {
 
     fn role(&self, region_id: RegionId) -> Option<RegionRole> {
         self.workers.get_region(region_id).map(|region| {
-            if region.is_writable() {
-                RegionRole::Leader
-            } else {
+            if region.is_readonly() {
                 RegionRole::Follower
+            } else {
+                RegionRole::Leader
             }
         })
     }

diff --git a/src/mito2/src/region.rs b/src/mito2/src/region.rs
@@ -174,6 +174,11 @@ impl MitoRegion {
         self.manifest_ctx.state.load() == RegionState::Writable
     }
 
+    /// Returns whether the region is readonly.
+    pub(crate) fn is_readonly(&self) -> bool {
+        self.manifest_ctx.state.load() == RegionState::ReadOnly
+    }
+
     /// Returns the state of the region.
     pub(crate) fn state(&self) -> RegionState {
         self.manifest_ctx.state.load()