Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl pubsub in metasrv #2045

Merged
merged 5 commits into from
Aug 3, 2023
Merged

feat: impl pubsub in metasrv #2045

merged 5 commits into from
Aug 3, 2023

Conversation

fengys1996
Copy link
Contributor

@fengys1996 fengys1996 commented Jul 31, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr mainly adds the pub/sub framework.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@fengys1996 fengys1996 marked this pull request as ready for review August 1, 2023 02:55
@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Merging #2045 (659c375) into develop (44f3ed2) will decrease coverage by 0.26%.
Report is 19 commits behind head on develop.
The diff coverage is 84.13%.

@@             Coverage Diff             @@
##           develop    #2045      +/-   ##
===========================================
- Coverage    85.13%   84.87%   -0.26%     
===========================================
  Files          672      683      +11     
  Lines       106129   106960     +831     
===========================================
+ Hits         90350    90783     +433     
- Misses       15779    16177     +398

MichaelScofield
MichaelScofield reviewed Aug 1, 2023
View reviewed changes
src/meta-srv/src/handler/report_handler.rs Outdated Show resolved Hide resolved
src/meta-srv/src/pubsub/publish.rs Show resolved Hide resolved
src/meta-srv/src/pubsub/publish.rs Outdated Show resolved Hide resolved
src/meta-srv/src/pubsub/subscribe_manager.rs Outdated Show resolved Hide resolved
@fengys1996
Copy link
Contributor Author

@MichaelScofield PTAL

fengjiachun
fengjiachun reviewed Aug 2, 2023
View reviewed changes
src/meta-srv/src/handler/report_handler.rs Outdated Show resolved Hide resolved
src/meta-srv/src/pubsub/subscribe_manager.rs Outdated Show resolved Hide resolved
src/meta-srv/src/metasrv.rs Outdated Show resolved Hide resolved
src/meta-srv/src/metasrv/builder.rs Outdated Show resolved Hide resolved
src/meta-srv/src/pubsub.rs Outdated Show resolved Hide resolved
@fengys1996
Copy link
Contributor Author

@fengjiachun PTAL

shuiyisong
shuiyisong reviewed Aug 2, 2023
View reviewed changes
src/servers/Cargo.toml Outdated Show resolved Hide resolved
fengjiachun
fengjiachun approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Aug 3, 2023
Merged via the queue into GreptimeTeam:develop with commit dda9225 Aug 3, 2023
@fengys1996 fengys1996 deleted the feat/pubsub branch August 3, 2023 04:29
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@fengys1996 @paomian
feat: impl pubsub in metasrv (GreptimeTeam#2045)
7e69668 
* feat: impl pubsub

* add test_subscriber_disconnect unit test

* chore: cr

* cr

* cr
@tisonkun tisonkun added the A-metasrv Involves code in the meta server label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuiyisong shuiyisong shuiyisong left review comments

@fengjiachun fengjiachun fengjiachun approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@paomian paomian Awaiting requested review from paomian

Assignees
No one assigned
Labels
A-metasrv Involves code in the meta server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fengys1996 @MichaelScofield @fengjiachun @shuiyisong @tisonkun