refactor: use workspace dependencies for internal modules #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunng87
force-pushed
the
refactor/workspace-members
branch
from
83bec1f to
a0d17a5
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2119 +/- ##
===========================================
- Coverage 84.88% 84.55% -0.34%
===========================================
Files 687 687
Lines 108586 108586
===========================================
- Hits 92176 91817 -359
- Misses 16410 16769 +359 |
waynexia
approved these changes
Aug 8, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…am#2119) * refactor: use workspace dependencies for internal modules * fix: resolve issue with mock module in datanode * refactor: update test modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This patch updates our cargo TOMLs to manage internal dependencies in workspace. In this manner, we built an abstraction between module name and actual implementation, by which we can replace implementation by configuring workspace toml.
Checklist
Refer to a related PR or issue link (optional)