-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: switch to new catalog/schema key #2140
Merged
fengjiachun
merged 3 commits into
GreptimeTeam:develop
from
WenyXu:feat/switch-to-new-catalog-schema-key
Aug 14, 2023
Merged
feat!: switch to new catalog/schema key #2140
fengjiachun
merged 3 commits into
GreptimeTeam:develop
from
WenyXu:feat/switch-to-new-catalog-schema-key
Aug 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
requested review from
MichaelScofield,
fengys1996,
paomian and
fengjiachun
and removed request for
MichaelScofield
August 10, 2023 05:19
Codecov Report
@@ Coverage Diff @@
## develop #2140 +/- ##
===========================================
- Coverage 84.88% 84.58% -0.30%
===========================================
Files 696 696
Lines 110476 110528 +52
===========================================
- Hits 93781 93495 -286
- Misses 16695 17033 +338 |
WenyXu
force-pushed
the
feat/switch-to-new-catalog-schema-key
branch
from
August 10, 2023 12:29
3458a0f
to
fcd5cb2
Compare
PTAL @MichaelScofield |
MichaelScofield
approved these changes
Aug 11, 2023
…ew-catalog-schema-key
fengjiachun
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat!: switch to new catalog/schema key * chore: apply suggestions from CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
switch to new catalog/schema key
Checklist
Refer to a related PR or issue link (optional)
close #2024