Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: switch to new catalog/schema key #2140

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Aug 10, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

switch to new catalog/schema key

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

close #2024

@WenyXu WenyXu added the breaking-change This pull request contains breaking changes. label Aug 10, 2023
@WenyXu WenyXu requested review from MichaelScofield, fengys1996, paomian and fengjiachun and removed request for MichaelScofield August 10, 2023 05:19
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #2140 (d927c74) into develop (0b05c22) will decrease coverage by 0.30%.
Report is 1 commits behind head on develop.
The diff coverage is 76.34%.

@@             Coverage Diff             @@
##           develop    #2140      +/-   ##
===========================================
- Coverage    84.88%   84.58%   -0.30%     
===========================================
  Files          696      696              
  Lines       110476   110528      +52     
===========================================
- Hits         93781    93495     -286     
- Misses       16695    17033     +338     

src/frontend/src/instance/distributed.rs Outdated Show resolved Hide resolved
src/meta-srv/src/metadata_service.rs Outdated Show resolved Hide resolved
src/meta-srv/src/service/admin/meta.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the feat/switch-to-new-catalog-schema-key branch from 3458a0f to fcd5cb2 Compare August 10, 2023 12:29
@WenyXu
Copy link
Member Author

WenyXu commented Aug 10, 2023

PTAL @MichaelScofield

@WenyXu WenyXu marked this pull request as draft August 11, 2023 14:42
@WenyXu WenyXu marked this pull request as ready for review August 11, 2023 15:17
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Aug 14, 2023
Merged via the queue into GreptimeTeam:develop with commit 5b012a1 Aug 14, 2023
22 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat!: switch to new catalog/schema key

* chore: apply suggestions from CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This pull request contains breaking changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor CatalogKey and SchemaKey
3 participants