Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix ddl client can not update leader addr #2205

Merged
merged 5 commits into from
Aug 21, 2023
Merged

fix: fix ddl client can not update leader addr #2205

merged 5 commits into from
Aug 21, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Aug 18, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fix DDL client can not update leader address

Screenshot 2023-08-18 at 16 51 38

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu marked this pull request as draft August 21, 2023 02:44
@WenyXu WenyXu marked this pull request as ready for review August 21, 2023 03:45
@WenyXu
Copy link
Member Author

WenyXu commented Aug 21, 2023

@MichaelScofield @fengjiachun PTAL

@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Merging #2205 (3c77074) into develop (033b650) will decrease coverage by 0.45%.
Report is 1 commits behind head on develop.
The diff coverage is 59.25%.

@@             Coverage Diff             @@
##           develop    #2205      +/-   ##
===========================================
- Coverage    84.65%   84.21%   -0.45%     
===========================================
  Files          700      700              
  Lines       112678   112742      +64     
===========================================
- Hits         95390    94942     -448     
- Misses       17288    17800     +512

@WenyXu WenyXu marked this pull request as draft August 21, 2023 04:25
@WenyXu WenyXu marked this pull request as ready for review August 21, 2023 06:12
killme2008
killme2008 reviewed Aug 21, 2023
View reviewed changes
src/meta-client/src/error.rs Outdated Show resolved Hide resolved
src/meta-client/src/client/ddl.rs Show resolved Hide resolved
@WenyXu WenyXu marked this pull request as draft August 21, 2023 07:06
@WenyXu WenyXu marked this pull request as ready for review August 21, 2023 07:23
fengjiachun
fengjiachun approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Aug 21, 2023
Merged via the queue into GreptimeTeam:develop with commit 5b7b2cf Aug 21, 2023
13 checks passed
@WenyXu WenyXu added the O-chaos Found by chaos tests label Sep 19, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@WenyXu @paomian
fix: fix ddl client can not update leader addr (GreptimeTeam#2205)
02b379a 
* fix: fix ddl client can not update leader addr

* chore: apply suggestions from CR

* feat: add message to context

* fix: only retry if unavailable or deadline exceeded

* chore: apply suggestions from CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelScofield MichaelScofield MichaelScofield left review comments

@killme2008 killme2008 killme2008 left review comments

@waynexia waynexia waynexia approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
O-chaos Found by chaos tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WenyXu @killme2008 @MichaelScofield @fengjiachun @waynexia