-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl kv backend for raft engine #2280
Merged
fengjiachun
merged 6 commits into
GreptimeTeam:migrate-region-server
from
v0y4g3r:feat/kv-backend-for-raft-engine
Sep 1, 2023
Merged
feat: impl kv backend for raft engine #2280
fengjiachun
merged 6 commits into
GreptimeTeam:migrate-region-server
from
v0y4g3r:feat/kv-backend-for-raft-engine
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## migrate-region-server #2280 +/- ##
=========================================================
- Coverage 85.27% 78.30% -6.98%
=========================================================
Files 709 706 -3
Lines 116304 115370 -934
=========================================================
- Hits 99176 90336 -8840
- Misses 17128 25034 +7906 |
fengjiachun
reviewed
Aug 29, 2023
fengjiachun
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
MichaelScofield
approved these changes
Aug 31, 2023
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* feat: kv backend on raft-engine * feat: raft-engine kvbackend * fix: toml * fix: some review comments * chore: optimize delete * fix: lift lock in batch_delete
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* feat: kv backend on raft-engine * feat: raft-engine kvbackend * fix: toml * fix: some review comments * chore: optimize delete * fix: lift lock in batch_delete
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* feat: kv backend on raft-engine * feat: raft-engine kvbackend * fix: toml * fix: some review comments * chore: optimize delete * fix: lift lock in batch_delete
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
Sep 13, 2023
* feat: kv backend on raft-engine * feat: raft-engine kvbackend * fix: toml * fix: some review comments * chore: optimize delete * fix: lift lock in batch_delete
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: kv backend on raft-engine * feat: raft-engine kvbackend * fix: toml * fix: some review comments * chore: optimize delete * fix: lift lock in batch_delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements
KvBackend
based on kv-api provided by raft-engine.Checklist
Refer to a related PR or issue link (optional)
closes #2215