Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl kv backend for raft engine #2280

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Aug 29, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR implements KvBackend based on kv-api provided by raft-engine.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

closes #2215

@v0y4g3r v0y4g3r marked this pull request as ready for review August 29, 2023 12:27
@v0y4g3r v0y4g3r requested review from waynexia, MichaelScofield and fengjiachun and removed request for waynexia August 29, 2023 12:31
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #2280 (9780a96) into migrate-region-server (e2522df) will decrease coverage by 6.98%.
Report is 17 commits behind head on migrate-region-server.
The diff coverage is 70.56%.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           migrate-region-server    #2280      +/-   ##
=========================================================
- Coverage                  85.27%   78.30%   -6.98%     
=========================================================
  Files                        709      706       -3     
  Lines                     116304   115370     -934     
=========================================================
- Hits                       99176    90336    -8840     
- Misses                     17128    25034    +7906     

@v0y4g3r
Copy link
Contributor Author

v0y4g3r commented Aug 30, 2023

@MichaelScofield @fengjiachun PTAL

@waynexia waynexia changed the base branch from develop to migrate-region-server August 30, 2023 07:46
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fengjiachun fengjiachun added this pull request to the merge queue Sep 1, 2023
Merged via the queue into GreptimeTeam:migrate-region-server with commit d91997e Sep 1, 2023
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: kv backend on raft-engine

* feat: raft-engine kvbackend

* fix: toml

* fix: some review comments

* chore: optimize delete

* fix: lift lock in batch_delete
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: kv backend on raft-engine

* feat: raft-engine kvbackend

* fix: toml

* fix: some review comments

* chore: optimize delete

* fix: lift lock in batch_delete
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: kv backend on raft-engine

* feat: raft-engine kvbackend

* fix: toml

* fix: some review comments

* chore: optimize delete

* fix: lift lock in batch_delete
WenyXu pushed a commit to WenyXu/greptimedb that referenced this pull request Sep 13, 2023
* feat: kv backend on raft-engine

* feat: raft-engine kvbackend

* fix: toml

* fix: some review comments

* chore: optimize delete

* fix: lift lock in batch_delete
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: kv backend on raft-engine

* feat: raft-engine kvbackend

* fix: toml

* fix: some review comments

* chore: optimize delete

* fix: lift lock in batch_delete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement KvBackend for RaftEngineLogStore
3 participants