Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: revert ignored tests #2455

Merged

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Sep 20, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Revert two ignored tests.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2401

@killme2008 killme2008 marked this pull request as ready for review September 20, 2023 13:33
@killme2008 killme2008 requested review from waynexia and MichaelScofield and removed request for waynexia September 20, 2023 13:33
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2455 (2992ad1) into develop (23cc7d8) will decrease coverage by 0.36%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2455      +/-   ##
===========================================
- Coverage    84.81%   84.45%   -0.36%     
===========================================
  Files          727      727              
  Lines       114977   114977              
===========================================
- Hits         97517    97105     -412     
- Misses       17460    17872     +412     

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Sep 21, 2023
Merged via the queue into GreptimeTeam:develop with commit 9863e50 Sep 21, 2023
23 of 24 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@killme2008 killme2008 deleted the feature/ignored-test branch January 16, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants