feat: limit grpc message size #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those options are for: * Limit receiving(decoding) message size * Limit sending(enoding) message size
|
Please note that I don't apply recv/send message limit to meta server, since I think it may not needed. If it's needed please mention it and tell which service need the limitation:
|
TheWaWaR
force-pushed
the
limit-grpc-message-size
branch
2 times, most recently
from
9fa234b
to
4a74c34
Compare
TheWaWaR
force-pushed
the
limit-grpc-message-size
branch
from
4a74c34
to
1487d0f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2459 +/- ##
===========================================
- Coverage 84.85% 84.45% -0.41%
===========================================
Files 727 726 -1
Lines 114977 115040 +63
===========================================
- Hits 97568 97158 -410
- Misses 17409 17882 +473 |
MichaelScofield
approved these changes
Sep 22, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: add two grpc config options Those options are for: * Limit receiving(decoding) message size * Limit sending(enoding) message size * test: add integration tests for message size limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Limit grpc client/server message size
Please explain IN DETAIL what the changes are in this PR and why they are needed:
max_decoding_message_size/max_encoding_message_sizeconfigurablemax_decoding_message_size/max_encoding_message_sizeconfigurableChecklist
Refer to a related PR or issue link (optional)
#2220