-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preserve arg to sqlness runner #3724
feat: add preserve arg to sqlness runner #3724
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
==========================================
- Coverage 85.43% 85.12% -0.31%
==========================================
Files 966 966
Lines 162088 162088
==========================================
- Hits 138482 137984 -498
- Misses 23606 24104 +498 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@waynexia sqlness test failed |
Do you have any idea about the compatibility test @MichaelScofield ? It now relies on "dirty sqlness state", which is a bug IMHO. I'm going to comment out that test until we find a better way to test the compatibility |
E.g.: maintain a dedicated Python script to create tables and write data into two versions and compare them. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Add
--preserve-state
CLI arg to prevent temp dir from cleaning on exit. Sqlness runner in CI will use it to preserve logs and state.Usetempdir
becausetempfile
cannot set a prefix on temp dir.Checklist