Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set is_time_index properly on updating physical table's schema #3770

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Closes #3758

What's changed and what's your intention?

Related to this ticket: #2798

Only time_index in schema is set before, but forget to set this on column_schema

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@waynexia waynexia requested review from MichaelScofield and a team as code owners April 22, 2024 12:18
@waynexia waynexia requested review from evenyag and WenyXu April 22, 2024 12:18
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 22, 2024
@waynexia waynexia enabled auto-merge April 22, 2024 12:28
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (54432df) to head (2033dd8).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3770      +/-   ##
==========================================
- Coverage   85.55%   85.22%   -0.34%     
==========================================
  Files         945      946       +1     
  Lines      159357   159564     +207     
==========================================
- Hits       136337   135984     -353     
- Misses      23020    23580     +560     

@waynexia waynexia added this pull request to the merge queue Apr 22, 2024
Merged via the queue into GreptimeTeam:main with commit bf21527 Apr 22, 2024
19 checks passed
@waynexia waynexia deleted the fix-update-semantic branch April 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect semantic_type of the physical table.
3 participants