-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: push down order hint of the query again #3797
Conversation
ecdd227
to
141063b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3797 +/- ##
==========================================
- Coverage 85.56% 85.22% -0.34%
==========================================
Files 946 948 +2
Lines 161083 161168 +85
==========================================
- Hits 137827 137362 -465
- Misses 23256 23806 +550 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
LIMIT
#3274What's changed and what's your intention?
This PR fixes the issue that the region server doesn't push down the order hint of the query to the mito engine. This is the first step to optimize
order by ts
andorder by ts limit
statements.It moves the
DummyTableProvider
to thecommon-query
mod so theOptimizeRule
can correctly downcast the table provider and attach theOrderOption
to the provider.Now we can get the order hint in the mito engine:
Then the debug log shows the hint
Checklist