refactor: remove substrait ser/de for region query in standalone #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelScofield
force-pushed
the
refactor/no-serde-for-standalone-plan
branch
from
ee45357 to
7e77982
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3812 +/- ##
==========================================
- Coverage 85.43% 85.14% -0.30%
==========================================
Files 994 994
Lines 174348 174582 +234
==========================================
- Hits 148958 148642 -316
- Misses 25390 25940 +550 |
MichaelScofield
force-pushed
the
refactor/no-serde-for-standalone-plan
branch
from
7e77982 to
8aabf78
Compare
MichaelScofield
force-pushed
the
refactor/no-serde-for-standalone-plan
branch
from
8aabf78 to
e8c9d37
Compare
evenyag
reviewed
May 8, 2024
MichaelScofield
force-pushed
the
refactor/no-serde-for-standalone-plan
branch
2 times, most recently
from
48520a2 to
50ac605
Compare
evenyag
approved these changes
May 15, 2024
|
@waynexia Please take a look. |
|
I'm going to look into this after v0.8 release. |
MichaelScofield
force-pushed
the
refactor/no-serde-for-standalone-plan
branch
from
50ac605 to
da59aee
Compare
|
@waynexia PTAL |
MichaelScofield
force-pushed
the
refactor/no-serde-for-standalone-plan
branch
from
da59aee to
6cc8833
Compare
MichaelScofield
force-pushed
the
refactor/no-serde-for-standalone-plan
branch
from
6cc8833 to
333ce0f
Compare
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
waynexia
approved these changes
Jun 11, 2024
Signed-off-by: Ruihang Xia <[email protected]>
evenyag
reviewed
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
close #3520
This PR makes the logical plan in region query request not always be serialized to and deserialized from substrait bytes, which is not necessary in standalone mode.
Checklist