Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit total rows copied in COPY TABLE FROM stmt #3819

Merged
merged 12 commits into from
May 7, 2024

Conversation

irenjj
Copy link
Collaborator

@irenjj irenjj commented Apr 27, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3714

What's changed and what's your intention?

limit total rows copied in COPY TABLE FROM

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 27, 2024
@irenjj irenjj marked this pull request as ready for review April 29, 2024 14:51
@irenjj irenjj requested a review from a team as a code owner April 29, 2024 14:51
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.30%. Comparing base (701aba9) to head (c604908).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3819      +/-   ##
==========================================
- Coverage   85.64%   85.30%   -0.34%     
==========================================
  Files         954      952       -2     
  Lines      163037   163297     +260     
==========================================
- Hits       139625   139300     -325     
- Misses      23412    23997     +585     

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. A few style suggestions.

@WenyXu
Copy link
Member

WenyXu commented Apr 30, 2024

@v0y4g3r v0y4g3r self-requested a review May 7, 2024 07:06
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r requested review from tisonkun and WenyXu May 7, 2024 15:27
@v0y4g3r
Copy link
Contributor

v0y4g3r commented May 7, 2024

@irenjj Just forgot to mention that the docs for copy statement also needs to be updated.

@github-actions github-actions bot added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels May 7, 2024
@tisonkun tisonkun added this pull request to the merge queue May 7, 2024
Merged via the queue into GreptimeTeam:main with commit 5274806 May 7, 2024
23 checks passed
@waynexia
Copy link
Member

waynexia commented May 8, 2024

Are you willing to take the follow-up task to make this limit configurable? @irenjj

@irenjj
Copy link
Collaborator Author

irenjj commented May 8, 2024

@irenjj Just forgot to mention that the docs for copy statement also needs to be updated.

Sure, Could you help review it?

@irenjj
Copy link
Collaborator Author

irenjj commented May 8, 2024

Are you willing to take the follow-up task to make this limit configurable? @irenjj

I'd like to, Could you please give me a little hint?

@irenjj irenjj deleted the limit_copy_rows branch May 8, 2024 12:59
@waynexia
Copy link
Member

waynexia commented May 9, 2024

Are you willing to take the follow-up task to make this limit configurable? @irenjj

I'd like to, Could you please give me a little hint?

Filed #3889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limiting total rows copied in COPY TABLE FROM statement
5 participants