-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: limit total rows copied in COPY TABLE FROM
stmt
#3819
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3819 +/- ##
==========================================
- Coverage 85.64% 85.30% -0.34%
==========================================
Files 954 952 -2
Lines 163037 163297 +260
==========================================
- Hits 139625 139300 -325
- Misses 23412 23997 +585 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. A few style suggestions.
Could you add a sqlness test? Here are some examples: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@irenjj Just forgot to mention that the docs for |
Are you willing to take the follow-up task to make this limit configurable? @irenjj |
Sure, Could you help review it? |
I'd like to, Could you please give me a little hint? |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #3714
What's changed and what's your intention?
limit total rows copied in
COPY TABLE FROM
Checklist