-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move database client to test #3820
refactor: move database client to test #3820
Conversation
@MichaelScofield PTAL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3820 +/- ##
==========================================
- Coverage 85.60% 85.41% -0.19%
==========================================
Files 955 952 -3
Lines 163104 162881 -223
==========================================
- Hits 139625 139127 -498
- Misses 23479 23754 +275 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC we'd letter use https://github.com/GreptimeTeam/greptimedb-ingester-rust.
Although we may not couple this patch with the migration to https://github.com/GreptimeTeam/greptimedb-ingester-rust, we can think of it.
@MichaelScofield It is ready for review, please take a look. |
@tisonkun PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'll try to delete methods unused in the Database
struct.
For further development, I suppose we should make a utility to talk to the server in HTTP API and finally remove all these code. Because we're going to remove the Query
variant in GreptimeRequest and most test purpose SQL should be able to run via HTTP API.
And ingestions depend on the Rust ingester library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next step is replace Database with HTTP API, Rust ingester, or others.
Signed-off-by: tison <[email protected]>
cd6f55a
to
af71593
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Closes #3798
What's changed and what's your intention?
Database
client incli export
Database
totests-integration
Checklist