Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use txn to impl cas #3936

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

There is a long story to tell. Initially, we implemented compare_and_put, and later incorporated Txn.
As a result, there were multiple implementations of compare_and_put in our KvBackends that we need to maintain consistent behavior with.
With the introduction of Txn, it became easier for us to implement compare_and_put. In this PR, I utilized Txn for its implementation and removed all other methods.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 14, 2024
@fengjiachun fengjiachun requested a review from WenyXu May 14, 2024 07:29
@fengjiachun fengjiachun added this pull request to the merge queue May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.48%. Comparing base (00e21e2) to head (8e61a1b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3936      +/-   ##
==========================================
- Coverage   85.83%   85.48%   -0.35%     
==========================================
  Files         964      965       +1     
  Lines      165047   164993      -54     
==========================================
- Hits       141660   141040     -620     
- Misses      23387    23953     +566     

Merged via the queue into GreptimeTeam:main with commit a260ba3 May 14, 2024
22 checks passed
@fengjiachun fengjiachun deleted the feat/cas-txn-impl branch May 14, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants